Skip to content

Fix flag embedding#41

Open
Parry-Parry wants to merge 4 commits intoterrierteam:mainfrom
Parry-Parry:fix-flag-embedding
Open

Fix flag embedding#41
Parry-Parry wants to merge 4 commits intoterrierteam:mainfrom
Parry-Parry:fix-flag-embedding

Conversation

@Parry-Parry
Copy link
Contributor

Stops uncaught import errors and instead skips tests when FlagEmbedding is not installed, additionally does minor formatting on the bge file.

@cmacdonald
Copy link
Collaborator

tests seems to be failing because the GHA local disk is full - is this because we're downloading too many model checkpoints?

@Parry-Parry
Copy link
Contributor Author

tests seems to be failing because the GHA local disk is full - is this because we're downloading too many model checkpoints?

We really should define some mocking of models e.g instantiating from a small BERT model, I could do this in another PR as it avoids actually downloading what is now a silly number of models

@seanmacavaney
Copy link
Collaborator

@Parry-Parry can you fix the merge conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants